elek commented on a change in pull request #2401:
URL: https://github.com/apache/ozone/pull/2401#discussion_r670479454
##########
File path: hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto
##########
@@ -519,6 +519,7 @@ message BucketInfo {
optional int64 quotaInBytes = 15 [default = -2];
optional int64 quotaInNamespace = 16 [default = -2];
optional uint64 usedNamespace = 17;
+ optional hadoop.hdds.ECReplicationConfig ecReplicationConfig = 18;
Review comment:
Based on the previous comment, I would suggest to
1. Store not only the `ecReplicationConfig` but the `RATIS/STANDALONE`
parameters. As we have no backward compatibility issue here we can create an
embedded structure which includes
`ecReplicationConfig/ratisReplicationConfig/standaloneReplicationConfig` we
don't really need to do the magic serialization used elsewhere
(ecReplicationConfig is de-serialized from the same structure in proto, but
ratisReplicationConfig is de-serialized from
`replicationType/replicationFactor`)
2. I would call it `defaultReplicationConfig` to show that it's nothing
more just an (optional) default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
