kerneltime commented on a change in pull request #2509:
URL: https://github.com/apache/ozone/pull/2509#discussion_r685420665



##########
File path: 
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/ObjectEndpoint.java
##########
@@ -858,15 +860,29 @@ private static int parsePartNumberMarker(String 
partNumberMarker) {
     return partMarker;
   }
 
-  private static long parseOzoneDate(String ozoneDateStr) throws OS3Exception {
+  // If the return is empty, the precondition should be ignored

Review comment:
       Can you please update this comment and others in the method.
   ```suggestion
     // Parses date string and return long representation. Returns an empty if 
DateStr is null or invalid. Date in the future are considered invalid.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to