kerneltime commented on a change in pull request #2509:
URL: https://github.com/apache/ozone/pull/2509#discussion_r685522738
##########
File path:
hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestMultipartUploadWithCopy.java
##########
@@ -208,6 +218,73 @@ public void testMultipartIfModifiedSince() throws
Exception {
}
}
+ // Test operations with 2 datestrings; one valid, the other invalid;
+ // confirm the invalid one is ignored and the valid precondition tested
Review comment:
Thank you for adding this, we should have 12 test cases or more, 4 based
on true and false condition for timestamps that are valid, 4 with either one of
the time stamps is null and the other true or false, 4 for ether timestamp in
the future and other time stamp true or false but valid and finally actual bad
input.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
