jojochuang commented on PR #11939:
URL: https://github.com/apache/ozone/pull/11939#issuecomment-6642407496

   Thanks for porting the missing v1 coverage, especially the operation tests 
that weren’t equivalent to the similarly named ownership-header tests. I have a 
few compatibility and coverage concerns:
   
   1. **Object Content-Type:** v1’s string `putObject` sets `text/plain`, while 
`RequestBody.fromBytes` defaults to `application/octet-stream`. Could we 
explicitly retain `.contentType("text/plain")` for ordinary Freon uploads and 
verify it through HEAD? Keeping the byte body also avoids the uppercase charset 
signature issue.
   
   2. **Credential aliases:** the v2 environment provider drops 
`AWS_ACCESS_KEY` and `AWS_SECRET_KEY`. Could we preserve these aliases with 
v1-compatible precedence, or explicitly document the breaking change? 
Credential-resolution tests would help establish the intended behavior.
   
   3. **Presigned unsupported subresources:** the removed v1 test checks 
presigned `?annotation` and `?torrent` requests return 501 without modifying 
the object. The typed-operation tests and the new successful custom-query test 
don’t cover that same path. Could we retain those cases using 
`putRawQueryParameter` with the v2 presigner?
   
   4. **Explicit part zero:** the new multipart GET test improves coverage of 
parts 1–3, but replaces the old explicit `partNumber=0` request with a request 
omitting the parameter. Could we retain an explicit-zero assertion that 
verifies the complete object is returned?
   
   The public Freon helper changes (`getS3()` return type and tracing-class 
rename), along with removal of the bundled v1 jars, would also be useful to 
call out in the compatibility notes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to