ArafatKhan2198 commented on code in PR #11960:
URL: https://github.com/apache/ozone/pull/11960#discussion_r4583525202
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/v2/pages/heatmap/heatmap.tsx:
##########
@@ -118,6 +118,9 @@ const Heatmap: React.FC<{}> = () => {
}
function handleSubmit() {
+ if (inputPathState.isInputPathValid === 'error') {
+ return;
+ }
Review Comment:
Could we also reset the validation error when the path is updated through
updateHeatmapParent()?
Currently, if a user enters an invalid path and then clicks a Heatmap block,
updateHeatmapParent() updates the input to a valid path but keeps
isInputPathValid as 'error'.
With this new check, clicking Search would still be blocked even though the
displayed path is valid.
Could we clear the validation state there and add a test for this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]