chihsuan commented on code in PR #11960:
URL: https://github.com/apache/ozone/pull/11960#discussion_r4598041989


##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/v2/pages/heatmap/heatmap.tsx:
##########
@@ -41,18 +41,23 @@ const DEFAULT_HEATMAP_RESPONSE: HeatmapResponse = {
   minAccessCount: 0
 };
 
+const INPUT_PATH_REGEX = /^[a-zA-Z0-9_./-]*$/;

Review Comment:
   @sravani-revuri Look again, I think the regex itself may be too strict. 
Ozone doesn't restrict key name characters by default 
([config](https://github.com/apache/ozone/blob/42ddc7a144630baa34459f326ab9c8988a82418a/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/OmConfig.java#L58-L60)),
 so a key like `dir
     1/report.csv` is valid but can't be searched now. Could we drop the check 
and encode the path instead?
   
   Because what's valid depends on cluster config, any frontend regex can block 
real paths, while a typo just shows **No Data available**. Sorry for the back 
and forth!
   
   cc @ArafatKhan2198 
   
   
   <img width="1440" height="860" alt="image" 
src="https://github.com/user-attachments/assets/a17b8618-a2d5-4eef-b8b1-024a702b0dca";
 />



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to