chihsuan commented on code in PR #11960:
URL: https://github.com/apache/ozone/pull/11960#discussion_r4585941275
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/v2/pages/heatmap/heatmap.tsx:
##########
@@ -118,6 +118,9 @@ const Heatmap: React.FC<{}> = () => {
}
function handleSubmit() {
+ if (inputPathState.isInputPathValid === 'error') {
+ return;
+ }
Review Comment:
+1 to clearing it. I wonder if we could derive the validity from `inputPath`
during render, so no path can leave it stale. See [Avoid redundant
state](https://react.dev/learn/choosing-the-state-structure#avoid-redundant-state).
This may need the `.` regex fix first, otherwise drilling into `my.bucket`
could show the error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]