jojochuang commented on a change in pull request #2706:
URL: https://github.com/apache/ozone/pull/2706#discussion_r726726617
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/upgrade/OMPrepareRequest.java
##########
@@ -248,10 +252,12 @@ public static void takeSnapshotAndPurgeLogs(long
prepareIndex,
"than prepare index %d. Some required logs may not have" +
" been removed.", actualPurgeIndex, prepareIndex));
}
- } catch (Exception e) {
+ } catch (ExecutionException e) {
// Ozone manager error handler does not respect exception chaining and
// only displays the message of the top level exception.
throw new IOException("Unable to purge logs: " + e.getMessage());
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
Review comment:
need to throw an exception here otherwise the caller may think the
method completed successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
