jojochuang commented on a change in pull request #2706:
URL: https://github.com/apache/ozone/pull/2706#discussion_r726726878
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/XceiverServerRatis.java
##########
@@ -583,8 +585,10 @@ public void submitRequest(ContainerCommandRequestProto
request,
try {
reply = server.submitClientRequestAsync(raftClientRequest)
.get(requestTimeout, TimeUnit.MILLISECONDS);
- } catch (Exception e) {
+ } catch (ExecutionException | TimeoutException e) {
throw new IOException(e.getMessage(), e);
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
Review comment:
need to throw an exception here otherwise the next line will encounter
an NPE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]