JacksonYao287 edited a comment on pull request #2808: URL: https://github.com/apache/ozone/pull/2808#issuecomment-966943333
thanks very much @siddhantsangwan for the review, i have updated the patch , please take a look! >By removing withinThresholdUtilizedNodes, we rely on the user setting a suitable threshold to make balancing work in such cases. i do get your point @Siddhant Sangwan. i think the main difference between our ideas is what should balancer exactly do. in your opinion, balancer should always try its best to make the cluster more balanced，no matter what the threshold is. but in mine, balancer just try to make the cluster balanced to what the threshold specified, if we want the cluster to be more balanced, we should specified a smaller threshold. on one hand, in practice, i think it easy to specified a smaller one if we find current threshold does not take any effect. on the other hand, if we want the cluster to be more balanced , we can not rely on balancer`s effort with a big threshold, because how balanced balancer will make the cluster to be is uncertain. specifying a smaller threshold will definitely work as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
