siddhantsangwan commented on pull request #2808: URL: https://github.com/apache/ozone/pull/2808#issuecomment-968678323
I think we should keep within threshold nodes. Removing them implies the user has to do a lot of work in first analyzing the cluster and then calculating a suitable threshold. The user can understandably expect to introduce one new node to the cluster and have balancer balance it with the default threshold. I don't see any down side in the current logic related to within threshold nodes. There's a bug that was pointed out by @JacksonYao287: > in some case , one container may be moved from a withinThresholdUtilized node to another withinThresholdUtilized node An easy fix for this is to remove `withinThresholdNodes` from `potentialTargets` when matching within threshold nodes with under utilized nodes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
