bharatviswa504 commented on a change in pull request #2886:
URL: https://github.com/apache/ozone/pull/2886#discussion_r766258987



##########
File path: 
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerRatisServer.java
##########
@@ -330,14 +330,45 @@ public void addOMToRatisRing(OMNodeDetails newOMNode) 
throws IOException {
     }
   }
 
+  /**
+   * Remove decommissioned OM node from Ratis ring
+   */
+  public void removeOMFromRatisRing(OMNodeDetails removeOMNode)
+      throws IOException {
+    Preconditions.checkNotNull(removeOMNode);
+
+    String removeNodeId = removeOMNode.getNodeId();

Review comment:
       I think after reading test understood, we can stop and then decomission. 
So, we don't need to worry about that if leader is the one being removed i 
think. Is my understanding correct?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to