hanishakoneru commented on a change in pull request #2886:
URL: https://github.com/apache/ozone/pull/2886#discussion_r767013830



##########
File path: 
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocolPB/OMAdminProtocolClientSideImpl.java
##########
@@ -86,16 +101,53 @@ public OMAdminProtocolClientSideImpl(ConfigurationSource 
conf,
     OMAdminProtocolPB proxy = RPC.getProtocolProxy(
         OMAdminProtocolPB.class,
         RPC.getProtocolVersion(OMAdminProtocolPB.class),
-        remoteOmNodeDetails.getRpcAddress(), ugi, hadoopConf,
+        omNodeDetails.getRpcAddress(), ugi, hadoopConf,
         NetUtils.getDefaultSocketFactory(hadoopConf),
         (int) OmUtils.getOMClientRpcTimeOut(conf), connectionRetryPolicy)
         .getProxy();
 
     RetryPolicy retryPolicy = 
RetryPolicies.retryUpToMaximumCountWithFixedSleep(
         10, 1000, TimeUnit.MILLISECONDS);
 
-    this.rpcProxy = (OMAdminProtocolPB) RetryProxy.create(
+    OMAdminProtocolPB rpcProxy = (OMAdminProtocolPB) RetryProxy.create(
         OMAdminProtocolPB.class, proxy, retryPolicy);
+
+    return new OMAdminProtocolClientSideImpl(rpcProxy,
+        omNodeDetails.getOMPrintInfo());
+  }
+
+  /**
+   * Create OM Admin Protocol Client for contacting the OM ring (failover
+   * till the current OM leader is reached). Use for admin commands such as
+   * decommissionOM which are should reach the OM leader.
+   */
+  public static OMAdminProtocolClientSideImpl createProxyForOMHA(
+      OzoneConfiguration conf, UserGroupInformation ugi, String omServiceId)
+      throws IOException {
+
+    RPC.setProtocolEngine(OzoneConfiguration.of(conf),
+        OMAdminProtocolPB.class, ProtobufRpcEngine.class);
+
+    OMFailoverProxyProvider omFailoverProxyProvider =
+        new OMFailoverProxyProvider(conf, ugi, omServiceId,
+            OMAdminProtocolPB.class);
+
+    // Multiple the max number of retries with number of OMs to calculate the

Review comment:
       Done.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to