hanishakoneru commented on a change in pull request #2886:
URL: https://github.com/apache/ozone/pull/2886#discussion_r767010850
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerRatisServer.java
##########
@@ -330,14 +330,45 @@ public void addOMToRatisRing(OMNodeDetails newOMNode)
throws IOException {
}
}
+ /**
+ * Remove decommissioned OM node from Ratis ring
+ */
+ public void removeOMFromRatisRing(OMNodeDetails removeOMNode)
+ throws IOException {
+ Preconditions.checkNotNull(removeOMNode);
+
+ String removeNodeId = removeOMNode.getNodeId();
Review comment:
With the current patch, we cannot remove leader OM. So yes, OM can be
stopped before decommissioning. But if there are only 2 OMs in the ring, and we
stop the follower to decommission, then the Leader will not be able to process
the SetConf request as it won't get the quorum.
So, the more general rule would be that decommissioning OM should not be the
leader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
