errose28 commented on a change in pull request #2917:
URL: https://github.com/apache/ozone/pull/2917#discussion_r770090849
##########
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/DBScanner.java
##########
@@ -61,8 +61,9 @@
private String tableName;
@CommandLine.Option(names = {"--with-keys"},
+ required = true,
Review comment:
Do we want to require this? I think we can pick a sensible default,
either true or false, and leave the flag optional.
##########
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/DBScanner.java
##########
@@ -61,8 +61,9 @@
private String tableName;
@CommandLine.Option(names = {"--with-keys"},
+ required = true,
description = "List Key -> Value instead of just Value.",
- defaultValue = "false",
+ defaultValue = "true",
Review comment:
I think with keys makes more sense defaulted to true, as I would expect
to see key->value pairs if reading a key-value store. Unless there's a common
case where the output is too verbose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
