cku328 commented on a change in pull request #2917:
URL: https://github.com/apache/ozone/pull/2917#discussion_r771114910
##########
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/DBScanner.java
##########
@@ -61,8 +61,9 @@
private String tableName;
@CommandLine.Option(names = {"--with-keys"},
+ required = true,
Review comment:
> Thanks to @errose28 ’s review, I think it’s better to change
`required` to `false` here. The purpose of using `false` is to allow users to
make choices according to their needs. What do you think?
According to [Picocli's package
documentation](https://picocli.info/apidocs/picocli/CommandLine.Option.html#required--),
the default value of this `required` element is `false`, so I think you just
need to delete this line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
