captainzmc commented on pull request #2939: URL: https://github.com/apache/ozone/pull/2939#issuecomment-999336940
> I think for now we can just add watchForCommit() after doing putBlock in [here](https://github.com/apache/ozone/blob/cd143c543780551e8cc77bcf201ba74125f90dea/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockDataStreamOutput.java#L306) which should solve the issue right away, Thanks @sadanand48 for your advice, I have updated the PR and the testPutBlockAtBoundary can be used to verify this fix. Through testing, I found that only add watchForCommit() is not enough. ExecutePutBlock() is only an asynchronous to execute updateCommitInfoMap. we should add waitOnFlushFutures() for ensure that updateCommitInfoMap is executed. Without waitOnFlushFutures() we'll have the same problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
