sadanand48 commented on a change in pull request #2939:
URL: https://github.com/apache/ozone/pull/2939#discussion_r773694789
##########
File path:
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/StreamCommitWatcher.java
##########
@@ -172,28 +172,17 @@ private void adjustBuffers(long commitIndex) {
}
}
- private long releaseBuffers(List<Long> indexes) {
+ private void releaseBuffers(List<Long> indexes) {
Preconditions.checkArgument(!commitIndexMap.isEmpty());
for (long index : indexes) {
Preconditions.checkState(commitIndexMap.containsKey(index));
final List<StreamBuffer> buffers = commitIndexMap.remove(index);
- final long length =
- buffers.stream().mapToLong(StreamBuffer::position).sum();
- totalAckDataLength += length;
Review comment:
I don't think we can remove the totalAckDataLength computation part
because this is used during
[retry](https://github.com/apache/ozone/blob/cd143c543780551e8cc77bcf201ba74125f90dea/hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/KeyDataStreamOutput.java#L281)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
