captainzmc commented on pull request #2939: URL: https://github.com/apache/ozone/pull/2939#issuecomment-999346883
@sadanand48 Oops! I found that our cleanup of futureMap in releaseBuffers was redundant. We have called the [commitWatcher cleanup](https://github.com/apache/ozone/blob/HDDS-4454/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockDataStreamOutput.java#L561) in close. Since futureMap doesn't store much and doesn't affect the client's memory, we can simply have it clean up on close. Let's just delete this part so it looks simpler and cleaner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
