JacksonYao287 commented on a change in pull request #2953:
URL: https://github.com/apache/ozone/pull/2953#discussion_r800297154
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMHAManagerImpl.java
##########
@@ -337,8 +337,8 @@ void reloadSCMState()
public void shutdown() throws IOException {
if (ratisServer != null) {
ratisServer.stop();
- ratisServer.getSCMStateMachine().close();
grpcServer.stop();
+ ratisServer.getSCMStateMachine().close();
Review comment:
if we want stateMachine#close to terminate the running process, i think
it is better to stop grpc server before the process is terminated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
