JacksonYao287 commented on a change in pull request #2953:
URL: https://github.com/apache/ozone/pull/2953#discussion_r800297970
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java
##########
@@ -1507,6 +1509,13 @@ public void stop() {
}
scmSafeModeManager.stop();
+
+ try {
+ LOG.info("Stopping SCM HA services.");
+ scmHAManager.shutdown();
+ } catch (Exception ex) {
+ LOG.error("SCM HA Manager stop failed", ex);
+ }
Review comment:
`scmHAManager.shutdown()` will call `stateMachine#close`. if we want
`stateMachine#close` to terminate the running process, i think it is better to
stop all other servers before the process is terminated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
