JacksonYao287 commented on a change in pull request #2953:
URL: https://github.com/apache/ozone/pull/2953#discussion_r822371622
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMHAManagerImpl.java
##########
@@ -337,7 +337,7 @@ void reloadSCMState()
public void shutdown() throws IOException {
if (ratisServer != null) {
ratisServer.stop();
- ratisServer.getSCMStateMachine().close();
+ ratisServer.getSCMStateMachine().stop();
Review comment:
thanks for pointing out this , this is indeed not the right place to
call `terminate`. i think we can put `terminate` in `scm#stop`, so when
`scm#stop` is called , all the service will be stopped and then the SCM process
will be terminated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
