siddhantsangwan commented on a change in pull request #2944:
URL: https://github.com/apache/ozone/pull/2944#discussion_r805505338
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancer.java
##########
@@ -108,35 +118,24 @@
* new ContainerBalancerConfiguration and ContainerBalancerMetrics.
* Container Balancer does not start on construction.
*
- * @param nodeManager NodeManager
- * @param containerManager ContainerManager
- * @param replicationManager ReplicationManager
- * @param ozoneConfiguration OzoneConfiguration
+ * @param scm the storage container manager
*/
- public ContainerBalancer(
- NodeManager nodeManager,
- ContainerManager containerManager,
- ReplicationManager replicationManager,
- OzoneConfiguration ozoneConfiguration,
- final SCMContext scmContext,
- NetworkTopology networkTopology,
- PlacementPolicy placementPolicy) {
- this.nodeManager = nodeManager;
- this.containerManager = containerManager;
- this.replicationManager = replicationManager;
- this.ozoneConfiguration = ozoneConfiguration;
- this.config = ozoneConfiguration.
- getObject(ContainerBalancerConfiguration.class);
+ public ContainerBalancer(StorageContainerManager scm) {
+ this.nodeManager = scm.getScmNodeManager();
+ this.containerManager = scm.getContainerManager();
+ this.replicationManager = scm.getReplicationManager();
+ this.ozoneConfiguration = scm.getConfiguration();
+ this.config = new ContainerBalancerConfiguration();
Review comment:
This should probably remain:
```
this.config =
ozoneConfiguration.getObject(ContainerBalancerConfiguration.class);
```
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancer.java
##########
@@ -108,35 +118,24 @@
* new ContainerBalancerConfiguration and ContainerBalancerMetrics.
* Container Balancer does not start on construction.
*
- * @param nodeManager NodeManager
- * @param containerManager ContainerManager
- * @param replicationManager ReplicationManager
- * @param ozoneConfiguration OzoneConfiguration
+ * @param scm the storage container manager
Review comment:
NIT: extra whitespace
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancer.java
##########
@@ -184,7 +183,36 @@ private void balance() {
//run balancer infinitely
this.iterations = Integer.MAX_VALUE;
}
+
for (int i = 0; i < iterations && balancerRunning; i++) {
+ if (config.getTriggerDuEnable()) {
+ // before starting a new iteration, we trigger all the datanode
+ // to run `du`. this is an aggressive action, with which we can
+ // get more precise usage info of all datanodes before moving.
+ // this is helpful for container balancer to make more appropriate
+ // decisions. this will increase the disk io load of data nodes, so
+ // please enable it with caution.
+ sendRefreshUsageCommandToAllDNs();
Review comment:
Since balancer will only use healthy, in-service DNs, do we need to
trigger DU in all the DNs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
