fapifta commented on a change in pull request #3155:
URL: https://github.com/apache/ozone/pull/3155#discussion_r818896249
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/DatanodeVersion.java
##########
@@ -20,16 +20,30 @@
/**
* Versioning for datanode.
*/
-public final class DatanodeVersions {
+public enum DatanodeVersion {
- public static final int DEFAULT_VERSION = 0;
+ DEFAULT_VERSION(0, "Initial version"),
- public static final int SEPARATE_RATIS_PORTS_AVAILABLE = 1;
+ SEPARATE_RATIS_PORTS_AVAILABLE(1, "Version with separated Ratis port.");
- // this should always point to the latest version
- public static final int CURRENT_VERSION = SEPARATE_RATIS_PORTS_AVAILABLE;
Review comment:
Hmm... so sad I did not went to try this out, but apparently you are
right... I will change this shortly. Thank you for noting this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
