fapifta commented on pull request #3155: URL: https://github.com/apache/ozone/pull/3155#issuecomment-1062356094
Hi @errose28, thank you for the review and for the suggestions, I think the suggested design is way better than we had initially, so I have implemented the suggested changes, and fixed the comparisons I could find. Also thank you @adoroszlai for the discussions before, and the reviews. I think the reasonable next step is to switch to use the enum wherever we can, and just translate it to int over the wire in a separate JIRA, though before doing so, I would like to take a quick experiment with an idea to reduce the number of times we need to pass on the version because of DatanodeDetails#toProto. Based on the experiment results, I will create the follow up JIRAs tomorrow. After that and when this PR goes in you can expect an update on the OzoneManagerVersion related PR, and then I will also post the PR that introduces the usage of the OzoneManagerVersion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
