errose28 commented on a change in pull request #3155:
URL: https://github.com/apache/ozone/pull/3155#discussion_r822005870
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/protocol/DatanodeDetails.java
##########
@@ -415,7 +415,7 @@ public static DatanodeDetails getFromProtoBuf(
builder.setPersistedOpStateExpiry(persistedOpStateExpiryEpochSec);
final boolean handlesUnknownPorts =
- clientVersion >= VERSION_HANDLES_UNKNOWN_DN_PORTS;
+ clientVersion >= VERSION_HANDLES_UNKNOWN_DN_PORTS.version();
Review comment:
This looks broken with future version being -1, even though on the
surface it looks correct to the casual reader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
