sodonnel commented on a change in pull request #3179:
URL: https://github.com/apache/ozone/pull/3179#discussion_r825891018
##########
File path:
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/ListSubcommand.java
##########
@@ -65,9 +69,14 @@
"DELETING, DELETED)")
private HddsProtos.LifeCycleState state;
- @Option(names = {"--factor"},
- description = "Container factor(ONE, THREE)")
- private HddsProtos.ReplicationFactor factor;
+ @Option(names = {"-t", "--type"},
+ description = "Replication Type (RATIS, STANDALONE or EC)")
Review comment:
What do you mean by "can it be omitted"? Do you make take away the
--type option completely? I think we need to differentiate between RATIS
ONE/THREE and STAND_ALONE ONE/THREE. Also the other commands that expect
`--replication` also have the `-type` field.
Did you have another idea in mind that would let us get rid of `--type`
completely?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
