sodonnel commented on a change in pull request #3179:
URL: https://github.com/apache/ozone/pull/3179#discussion_r826315896
##########
File path:
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/ListSubcommand.java
##########
@@ -65,9 +69,14 @@
"DELETING, DELETED)")
private HddsProtos.LifeCycleState state;
- @Option(names = {"--factor"},
- description = "Container factor(ONE, THREE)")
- private HddsProtos.ReplicationFactor factor;
+ @Option(names = {"-t", "--type"},
+ description = "Replication Type (RATIS, STANDALONE or EC)")
Review comment:
The mixin option seems like a good idea for these "type" and
"replication" options. Do you think we should go ahead with this change as it
is, as it contains further client and server side changes. Then raise a new
Jira to add the mixin and update any other commands to use it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
