sodonnel commented on a change in pull request #3179:
URL: https://github.com/apache/ozone/pull/3179#discussion_r826439143



##########
File path: 
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/ListSubcommand.java
##########
@@ -65,9 +69,14 @@
           "DELETING, DELETED)")
   private HddsProtos.LifeCycleState state;
 
-  @Option(names = {"--factor"},
-      description = "Container factor(ONE, THREE)")
-  private HddsProtos.ReplicationFactor factor;
+  @Option(names = {"-t", "--type"},
+      description = "Replication Type (RATIS, STANDALONE or EC)")

Review comment:
       OK, sounds good. Do you think we need more changes here, or are we ready 
to commit and then go ahead with the mixin improvement?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to