sodonnel commented on code in PR #3391:
URL: https://github.com/apache/ozone/pull/3391#discussion_r870163396
##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -864,6 +864,14 @@
of max amount of pipelines which are OPEN.
</description>
</property>
+ <property>
Review Comment:
We the config is defined as it is in ECWriteableContainerProvider, using the
"Type Safe Config" definitions, at compile time, any config with those
annotations are added into a ozone-default-generated.xml file, so we don't need
to update the ozone-default.xml with this value.
The problem we have, is that half the project uses the old way
(SCMConfigKeys and ozone-default.xml) and half uses the new way. The project
direction is to adopt the new way, although I personally prefer the old way, as
it is simpler and easier to understand :-)
As the config is defined in the "new way" here, I think we should remove the
additions to ozone-default.xml and ScmConfigKeys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
