adoroszlai commented on PR #3391: URL: https://github.com/apache/ozone/pull/3391#issuecomment-1124830418
Thanks @kaijchen for the details. I think it's better to set custom `ozone.scm.ec.pipeline.minimum` in the test setup then, similar to this: https://github.com/apache/ozone/blob/5459b49538f16256a4e0f7d3c7f2981d0d7a9fae/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestBlockOutputStream.java#L84-L102 Part of the reason I would like to avoid cluttering the builder with config settings is HDDS-6713, since all such methods need to be overridden in subclass builder. But even if we had a single builder class, I don't think each config setting needs its own setter method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
