sodonnel commented on code in PR #3391:
URL: https://github.com/apache/ozone/pull/3391#discussion_r870300471
##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -864,6 +864,14 @@
of max amount of pipelines which are OPEN.
</description>
</property>
+ <property>
Review Comment:
I believe you can do something like this:
```
WritableECContainerProvider.WritableECContainerProviderConfig ecConf
=
conf.getObject(WritableECContainerProvider.WritableECContainerProviderConfig.class);
ecConf.setMinimumPipelines(10);
conf.setFromObject(ecConf);
```
As I said earlier, must more complex than just a simple constant and
default. I have seen new code added using the old way too. I feel the project
is in a bad place with having two different ways to set the config, but its a
big effort to move everything to the new way, and I am not sure everyone agrees
the new way is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
