sodonnel commented on code in PR #3606:
URL: https://github.com/apache/ozone/pull/3606#discussion_r924975687
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/SCMCommonPlacementPolicy.java:
##########
@@ -127,6 +126,28 @@ public ConfigurationSource getConf() {
*/
@Override
public List<DatanodeDetails> chooseDatanodes(
+ List<DatanodeDetails> excludedNodes, List<DatanodeDetails>
favoredNodes,
+ int nodesRequired, long metadataSizeRequired, long dataSizeRequired)
+ throws SCMException {
+ return chooseDatanodesInternal(
+ excludedNodes.stream()
+ .map(node->nodeManager.getNodeByUuid(node.getUuidString()))
+ .collect(Collectors.toList()),
+ favoredNodes, nodesRequired, metadataSizeRequired,
dataSizeRequired);
Review Comment:
Do we need to do something similar for favoredNodes as they are probably
passed from client to server over protobuf too. Not sure if they end up in the
topology class or not though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
