sodonnel commented on code in PR #3606:
URL: https://github.com/apache/ozone/pull/3606#discussion_r926012564
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/placement/algorithms/TestSCMContainerPlacementCapacity.java:
##########
@@ -127,7 +137,7 @@ public void chooseDatanodes() throws SCMException {
//when
List<DatanodeDetails> datanodeDetails = scmContainerPlacementRandom
- .chooseDatanodes(existingNodes, null, 1, 15, 15);
+ .chooseDatanodesInternal(existingNodes, null, 1, 15, 15);
Review Comment:
Should we be calling the public interface, ie chooseDatanodes in the tests,
rather than the Internal method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
