sodonnel commented on code in PR #3606:
URL: https://github.com/apache/ozone/pull/3606#discussion_r926014962
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/placement/algorithms/TestSCMContainerPlacementRackAware.java:
##########
@@ -107,24 +107,23 @@ private void setup(int datanodeCount) {
DatanodeDetails datanodeDetails =
MockDatanodeDetails.createDatanodeDetails(
hostname + i, rack + (i / NODE_PER_RACK));
+ datanodes.add(datanodeDetails);
+ cluster.add(datanodeDetails);
DatanodeInfo datanodeInfo = new DatanodeInfo(
- datanodeDetails, NodeStatus.inServiceHealthy(),
- UpgradeUtils.defaultLayoutVersionProto());
+ datanodeDetails, NodeStatus.inServiceHealthy(),
Review Comment:
Can you check the indentation on these lines - it looks wrong, although
checkstyle has passed it. I think most of the lines changed from here to the
bottom of the PR are all indented more than they need to be.
BTW, you can run checkstyle locally to see if the style is correct if you
change the indentation here. From the root of the repo run:
```
./hadoop-ozone/dev-support/checks/checkstyle.sh
```
Its the same in TestSCMContainerPlacementRackScatter.java too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
