adoroszlai commented on code in PR #3615:
URL: https://github.com/apache/ozone/pull/3615#discussion_r935169724
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogStateManagerImpl.java:
##########
@@ -213,6 +214,7 @@ public void increaseRetryCountOfTransactionInDB(
public int resetRetryCountOfTransactionInDB(ArrayList<Long> txIDs)
throws IOException {
for (long txId: txIDs) {
+ Objects.requireNonNull(txId, "transactionId cannot be null");
Review Comment:
This `requireNonNull` check is unnecessary.
`txIDs` may be `null`, or it may contain a `null` element. In both cases
`for (long txId: txIDs)` would fail before reaching `requireNonNull`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
