Xushaohong commented on code in PR #3615:
URL: https://github.com/apache/ozone/pull/3615#discussion_r935185145
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogStateManagerImpl.java:
##########
@@ -213,6 +214,7 @@ public void increaseRetryCountOfTransactionInDB(
public int resetRetryCountOfTransactionInDB(ArrayList<Long> txIDs)
throws IOException {
for (long txId: txIDs) {
+ Objects.requireNonNull(txId, "transactionId cannot be null");
Review Comment:
You are right. I should wait for Lokeshj to give a clarification on the
possible NPE. From my view, the lock should have prevented resetting the
nonexisting txIds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
