Xushaohong commented on code in PR #3615:
URL: https://github.com/apache/ozone/pull/3615#discussion_r934419870
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogStateManagerImpl.java:
##########
@@ -209,6 +209,23 @@ public void increaseRetryCountOfTransactionInDB(
}
}
+ @Override
+ public int resetRetryCountOfTransactionInDB(ArrayList<Long> txIDs)
+ throws IOException {
+ for (long txId: txIDs) {
+ DeletedBlocksTransaction transaction = deletedTable.get(txId);
Review Comment:
> > This is already handled in DeletedBlockLogImpl, only the filtered txns
will be processed.
>
> I think we should still handle this case, o.w we may end up hitting NPE.
Do you mean adding a null check here?
```suggestion
Objects.requireNonNull(txId, "transactionId cannot be null");
DeletedBlocksTransaction transaction = deletedTable.get(txId);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
