adoroszlai commented on code in PR #3643:
URL: https://github.com/apache/ozone/pull/3643#discussion_r935821678
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/HddsDispatcher.java:
##########
@@ -312,6 +312,7 @@ private ContainerCommandResponseProto dispatchRequest(
}
responseProto = handler.handle(msg, container, dispatcherContext);
if (responseProto != null) {
+ metrics.incContainerOpsMetrics(Type.CreateContainer);
metrics.incContainerOpsLatencies(cmdType,
Review Comment:
We shouldn't report `CreateContainer` op for "any" command.
The first attempt was fine: increment ops count if `container` is being
created inline for other (WriteChunk, PutSmallFile, etc.) commands. Latency
can be updated there, too, we just need to take note of start time, and use it
to calculate elapsed time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
