DaveTeng0 commented on PR #3643: URL: https://github.com/apache/ozone/pull/3643#issuecomment-1204068686
> Thanks for the patch. Have you verified unit tests? I suspect some tests in TestContainerMetrics need to update accordingly. I suggest to remove [calling createContainer](https://github.com/apache/ozone/pull/3643/files#diff-3d7dd1e263bbcdc0d201a231ebd91393746cd9ca653cff7de0bafc6b3047ae7dL127) cmd directly since createContainer happens only when write chunk to dataNode, please let me know how you think! @jojochuang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
