DaveTeng0 commented on code in PR #3643:
URL: https://github.com/apache/ozone/pull/3643#discussion_r935833851
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/container/metrics/TestContainerMetrics.java:
##########
@@ -125,11 +125,11 @@ public void testContainerMetrics() throws Exception {
client.connect();
// Create container
- ContainerCommandRequestProto request = ContainerTestHelper
- .getCreateContainerRequest(containerID, pipeline);
- ContainerCommandResponseProto response = client.sendCommand(request);
- Assert.assertEquals(ContainerProtos.Result.SUCCESS,
- response.getResult());
+// ContainerCommandRequestProto request = ContainerTestHelper
+// .getCreateContainerRequest(containerID, pipeline);
+// ContainerCommandResponseProto response = client.sendCommand(request);
+// Assert.assertEquals(ContainerProtos.Result.SUCCESS,
+// response.getResult());
Review Comment:
I feel we should probably remove the step of manually creating container
here, since container creation happens only as part of Write_Data phase of
writeChunk~?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
