adoroszlai commented on code in PR #3643:
URL: https://github.com/apache/ozone/pull/3643#discussion_r938150540
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/HddsDispatcher.java:
##########
@@ -261,6 +261,10 @@ private ContainerCommandResponseProto dispatchRequest(
// If container does not exist, create one for WriteChunk and
// PutSmallFile request
responseProto = createContainer(msg);
+ metrics.incContainerOpsMetrics(Type.CreateContainer);
+ metrics.incContainerOpsLatencies(Type.CreateContainer,
+ System.currentTimeMillis() - startTime);
Review Comment:
There's another call to `incContainerOpsLatencies`, for the real incoming
command:
https://github.com/apache/ozone/blob/7e3a77508f450121ba10d3a9d5a6713684cbf031/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/HddsDispatcher.java#L320-L321
I think we should change to `Time.monotonicNow()` there, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
