sodonnel commented on code in PR #3744:
URL: https://github.com/apache/ozone/pull/3744#discussion_r970958615
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/SCMCommonPlacementPolicy.java:
##########
@@ -146,8 +159,14 @@ object of DatanodeDetails(with Topology Information) while
trying to get the
random node from NetworkTopology should fix this. Check HDDS-7015
*/
return chooseDatanodesInternal(
+ Objects.isNull(usedNodes) ? Collections.emptyList()
Review Comment:
Might be a good idea to move the logic for handling the empty collection and
mapping it into a private method, as I think its duplicate here for used and
excluded nodes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
