swamirishi commented on code in PR #3744:
URL: https://github.com/apache/ozone/pull/3744#discussion_r971025496


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/placement/algorithms/SCMContainerPlacementRackAware.java:
##########
@@ -98,9 +99,11 @@ public SCMContainerPlacementRackAware(final NodeManager 
nodeManager,
    */
   @Override
   protected List<DatanodeDetails> chooseDatanodesInternal(
-      List<DatanodeDetails> excludedNodes, List<DatanodeDetails> favoredNodes,
-      int nodesRequired, long metadataSizeRequired, long dataSizeRequired)
-      throws SCMException {
+          List<DatanodeDetails> usedNodes,

Review Comment:
   Currently implementation has been done only for RackScatterPolicy. We have 
to change logic for other implementations as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to