sodonnel commented on code in PR #3744:
URL: https://github.com/apache/ozone/pull/3744#discussion_r970963707
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelinePlacementPolicy.java:
##########
@@ -215,8 +216,9 @@ private boolean
multipleRacksAvailable(List<DatanodeDetails> dns) {
*/
@Override
protected List<DatanodeDetails> chooseDatanodesInternal(
- List<DatanodeDetails> excludedNodes, List<DatanodeDetails> favoredNodes,
- int nodesRequired, long metadataSizeRequired, long dataSizeRequired)
+ List<DatanodeDetails> usedNodes, List<DatanodeDetails> excludedNodes,
Review Comment:
UsedNodes isn't used anywhere in this class, correct? If so, maybe add a
comment to the Java doc for that parameter to highlight that.
I also wonder if we should do anything if someone passes something non-empty
for used nodes here? Should we merge them into excludedNodes? Or throw an
exception of some sort to hightlight the passed value will not actually be used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
