xBis7 commented on code in PR #3750:
URL: https://github.com/apache/ozone/pull/3750#discussion_r971350019
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/ratis/TestOzoneManagerDoubleBufferWithOMResponse.java:
##########
@@ -469,7 +469,7 @@ private OMBucketCreateResponse createBucket(String
volumeName,
OzoneManagerProtocolProtos.OMRequest omRequest =
OMRequestTestUtils.createBucketRequest(bucketName, volumeName, false,
- OzoneManagerProtocolProtos.StorageTypeProto.DISK);
+ OzoneManagerProtocolProtos.StorageTypeProto.DISK, 0);
Review Comment:
@neils-dev `ClientVersion` has to be part of the proto OmRequest builder. We
can't change it later. If we don't set it, it initializes to default which is
0. All these tests were written for client version 0. I think it's best to not
change the client version for the existing tests. Most of these tests are
counting on getting a LEGACY bucket layout due to the client
version(`OMBucketCreateRequest.getDefaultBucketLayout()`). If we change that,
the tests will still get LEGACY layout because it's currently the default for
ozone. If at some point the default layout is not LEGACY then these tests will
end up broken. Instead of hardcoding 0, we can replace it with
`ClientVersion.DEFAULT_VERSION.toProtoValue()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
