neils-dev commented on code in PR #3750:
URL: https://github.com/apache/ozone/pull/3750#discussion_r979335205
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/bucket/TestBucketRequest.java:
##########
@@ -69,6 +69,9 @@ public void setup() throws Exception {
OzoneConfiguration ozoneConfiguration = new OzoneConfiguration();
ozoneConfiguration.set(OMConfigKeys.OZONE_OM_DB_DIRS,
folder.newFolder().getAbsolutePath());
+ ozoneConfiguration.set(OMConfigKeys.OZONE_DEFAULT_BUCKET_LAYOUT,
+ OMConfigKeys.OZONE_BUCKET_LAYOUT_FILE_SYSTEM_OPTIMIZED);
Review Comment:
It may be useful to declare the `ozoneConfiguration` variable at the class
level as a protected variable. Then allow the separate tests that extend the
class to change the default layout for the specific tests. In this case for
the `TestBucketRequest` the layout can be set to
`OZONE_DEFAULT_BUCKET_LAYOUT_DEFAULT `for consistency with the default
`OMConfigKeys`. Then in the tests it can be set when needed. For FSO specific
tests (`TestOMBucketCreateRequestWithFSO.java`), we can set the protected
OzoneConfiguration to FSO layout like:
`ozoneConfiguration.set(OMConfigKeys.OZONE_BUCKET_LAYOUT_FILE_SYSTEM_OPTIMIZED)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
