neils-dev commented on code in PR #3781:
URL: https://github.com/apache/ozone/pull/3781#discussion_r999702123
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DatanodeAdminMonitorImpl.java:
##########
@@ -90,6 +137,9 @@ public DatanodeAdminMonitorImpl(
this.eventQueue = eventQueue;
this.nodeManager = nodeManager;
this.replicationManager = replicationManager;
+
+ containerStateByHost = new HashMap<>();
+ pipelinesWaitingToCloseByHost = new HashMap<>();
Review Comment:
Split between replication state and pipelines was for grouping - they are
initialized and set in separate parts of the monitor code that resulted in
using two separate maps to store the two. Looking to, as suggested, reuse the
`ContainerStateInWorkflow `for the two, perhaps two different setters; one for
the replication and the other for pipelines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
