smengcl commented on code in PR #3821:
URL: https://github.com/apache/ozone/pull/3821#discussion_r999989500
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/spi/impl/OzoneManagerServiceProviderImpl.java:
##########
@@ -255,6 +265,22 @@ public void start() {
TimeUnit.MILLISECONDS);
}
+ private void stopSyncDataFromOMThread() {
+ scheduler.shutdownNow();
Review Comment:
Need to add another few lines of comments here:
1. `shutdownNow()` does not wait for executing task to terminate;
2. `stopSyncDataFromOMThread()` should only be called when no sync thread is
actively running
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
