smengcl commented on code in PR #3821:
URL: https://github.com/apache/ozone/pull/3821#discussion_r999991369
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/spi/impl/OzoneManagerServiceProviderImpl.java:
##########
@@ -255,6 +265,22 @@ public void start() {
TimeUnit.MILLISECONDS);
}
+ private void stopSyncDataFromOMThread() {
+ scheduler.shutdownNow();
Review Comment:
Let's add a sanity check here if possible. e.g. have a `Precondition` check
here that the return value of shutdownNow() should be an empty list:
```suggestion
Preconditions.checkState(scheduler.shutdownNow().isEmpty(),
"OM DB sync is still running!");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
